Replies includes my own account

When I reply to someone it includes my own account as well, which is not desired at all.

I'm running version 1.3.1 with Bitlbee 3.5.1 on Debian Stretch.

Tags: Closed

Reopen issue

Comments

Hm, that doesn’t happen to me. The code specifically excludes the current user. If you are mentioned twice, or a second account of yours is mentioned, that would look similar. Can you link to an example so I can take a look?

– Alex Schroeder 2018-08-17 22:40 UTC


Ah, found an example here.

– Alex Schroeder 2018-08-17 22:50 UTC


I think I know what the problem is: I guess I’m removing the current user from the mentions but not ignoreing case so Hund and hund are considered different? Something to look into.

– Alex Schroeder 2018-08-17 22:51 UTC


Yep, there it is: not ignoring case. Will fix this!

– Alex Schroeder 2018-08-17 22:53 UTC


I think this commit should fix it. What do you think?

– Alex Schroeder 2018-08-17 23:09 UTC


fastfinge report: «It does it whenever I type "reply <ID> <Message>".» Example. This doesn't seem to be case related.

– Alex Schroeder 2018-08-17 23:16 UTC


Here's what I tried. A conversation between kensanata@dice.camp and kensanata@octodon.social.

At dice.camp:

search https://octodon.social/@kensanata/100567708071840608**
[15] ...
vis direct
Next post is direct
reply 15 ...
**You: [16->15] @kensanata test**

At octodon.social:

[7a] @kensanata test
reply 7a test
You, direct: [7b->7a] @kensanata test

So it worked for me!

Now, just to make sure that md->user and the account mentioning me match up:

info 7a
...
mentions: [
 {
  id: 12540
  username: kensanata
  url: https://octodon.social/@kensanata
  acct: kensanata
 }
]
whois kensanata
This is you!

Everything seems to be in order! Can you also verify that the acct in the mentions of the status you are replying to matches your account name exactly, using whois?

– Alex Schroeder 2018-08-18 07:07 UTC


Possibly fixed. Two users reported that their actual usernames are their account names with two underscores (kensanata__ instead of kensanata). This breaks any tests for "is this my toot" and similar situations where we compare md->user (the nick) with an account->acct. The correct way to use md->user is only when parsing user commands. The user will refer to their account using their nick. Whenever we're checking for the user's account with data from the API, we must rely on the account_id. We have this data and saved it as part of the login process (in mastodon_verify_credentials), so compare that to any account->id.

– Alex Schroeder 2018-08-19 14:00 UTC


This wiki uses a variant of Markdown.

To save this page you must answer this question:

Please write "new issue" into the field below.